feat: extend signer to sign arbitrary message hashes #67
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pull request to allow wallets to sign messages without broadcasting them.
Ethereum had a lot of issues with this, so it will likely require some debate and the establishment of a standard on how messages are signed. See EIP 712 and EIP 191.
https://eips.ethereum.org/EIPS/eip-191
https://eips.ethereum.org/EIPS/eip-712
I know there's a lot of security issues around it, so I don't expect it to get approved without a lot of discussion and additional code, but I wanted to get the ball rolling by putting up some code to start.