feat: vertical additional space, header slot, scroll top and bottom event, linter added, removed less #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
j-d-carmichael
commented
Jan 11, 2021
•
j-d-carmichael
commented
- containerStyle is now the calculated height, plus the optionally injected spacer height
- header slot added sitting within the vue-virtual-collection but out of the vue-virtual-collection-container
- the vue-virtual-collection scroll at top and bottom event triggered allowing for pagination (infinite scroll) and fetch latest to occur
- less removed as the css is trivial thus less is overkil
- eslint added to ensure styles are uniform
- package.json scripts updated
- position by translateX and Y opposed to position top/left
added 7 commits
January 11, 2021 23:11
j-d-carmichael
changed the title
added 2 commits
January 12, 2021 18:11
added 9 commits
January 12, 2021 20:06
|
@starkwang any chance of getting this PR reviewed soon, could do with it published to npm for me CI pipes :) |
I'll review this PR ASAP. |
starkwang
reviewed
Jan 20, 2021
|
|
||
| Type: `number` | ||
|
|
||
| When injecting content into the header slot, you should also add the px height of the slot. This ensure items are removed from view at the right time. |
There was a problem hiding this comment.
Could you note default value of these props?
added 2 commits
January 20, 2021 14:40
|
Thanks for your contribution! @johndcarmichael |
|
Landed in 1.5.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.