-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove &self in AccountTransaction::handle_fee #1817
base: main
Are you sure you want to change the base?
Conversation
@noaov1 any opinion? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @Subsegment and @tdelabro)
crates/blockifier/src/transaction/account_transaction.rs
line 306 at r3 (raw file):
fn handle_fee<S: StateReader>(
Why did you add an additional new line?
Code quote:
}
fn handle_fee<S: StateReader>(
It may be a misoperation during merge conflict. I will modify it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @tdelabro)
@noaov1 thanks for the reviews. Can you also trigger the workflow? |
#1770
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)