Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: derive serialize for FeeTokenAddress and ChainInfo #1896

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ArniStarkware
Copy link
Contributor

@ArniStarkware ArniStarkware commented May 13, 2024

This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.88%. Comparing base (63c8b7e) to head (88d3ef4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1896      +/-   ##
==========================================
+ Coverage   77.80%   77.88%   +0.08%     
==========================================
  Files          61       61              
  Lines        8749     8781      +32     
  Branches     8749     8781      +32     
==========================================
+ Hits         6807     6839      +32     
  Misses       1502     1502              
  Partials      440      440              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Yael-Starkware Yael-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9 of 9 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ArniStarkware)


crates/blockifier/src/context.rs line 83 at r2 (raw file):

#[derive(Clone, Debug, Deserialize, PartialEq, Serialize, Validate)]
pub struct ChainInfo {

consider moving this struct in the future to starknet-api

Code quote:

pub struct ChainInfo 

crates/blockifier/src/context_test.rs line 27 at r2 (raw file):

fn test_valid_config_body<
    T: for<'a> Deserialize<'a> + SerializeConfig + Validate + PartialEq + Debug,

is Deserialize required here? I only see the usage of serialize.

Code quote:

Deserialize

@ArniStarkware ArniStarkware force-pushed the arni/mempool/config/chain_info/impl_serialize_config branch from d34cee3 to 88d3ef4 Compare May 20, 2024 14:43
Copy link
Contributor Author

@ArniStarkware ArniStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 8 of 9 files reviewed, 1 unresolved discussion (waiting on @Yael-Starkware)


crates/blockifier/src/context.rs line 83 at r2 (raw file):

Previously, Yael-Starkware (YaelD) wrote…

consider moving this struct in the future to starknet-api

Added a TODO.


crates/blockifier/src/context_test.rs line 27 at r2 (raw file):

Previously, Yael-Starkware (YaelD) wrote…

is Deserialize required here? I only see the usage of serialize.

get_config_from_file requires Deserialize

Copy link
Contributor

@Yael-Starkware Yael-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 8 of 9 files reviewed, all discussions resolved (waiting on @ArniStarkware)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants