Dori/ec op builtin

[dorimedini-starkware]

This change is 

[orizi]

Reviewed 13 of 13 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)

---

crates/cairo-lang-starknet/src/db.rs line 19 at r1 (raw file):

    // Override implicit precedence for compatibility with the StarkNet OS.
    db.set_implicit_precedence(Arc::new(
        ["Pedersen", "RangeCheck", "Bitwise", "GasBuiltin", "System", "EcOp"]

this is certainly not the correct order.
i think it is:

Suggestion:

        ["Pedersen", "RangeCheck", "Bitwise", "EcOp", "GasBuiltin", "System"]

[orizi]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dorimedini-starkware)

---

crates/cairo-lang-sierra/src/extensions/modules/builtin_cost.rs line 49 at r1 (raw file):

            CostTokenType::Step => panic!("offset_in_builtin_costs is not supported for 'Step'."),
            CostTokenType::Pedersen => 0,
            CostTokenType::EcOp => 2,

why did you decide on this number?

Code quote:

            CostTokenType::EcOp => 2,

[dorimedini-starkware]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @orizi)

---

crates/cairo-lang-sierra/src/extensions/modules/builtin_cost.rs line 49 at r1 (raw file):

Previously, orizi wrote…

why did you decide on this number?

because I'm prepping for this to be merged first

---

crates/cairo-lang-starknet/src/db.rs line 19 at r1 (raw file):

Previously, orizi wrote…

this is certainly not the correct order.
i think it is:

Done. Where can I see the correct order?

[dorimedini-starkware]

Reviewable status: 11 of 13 files reviewed, 2 unresolved discussions (waiting on @orizi)

---

crates/cairo-lang-sierra/src/extensions/modules/builtin_cost.rs line 49 at r1 (raw file):

Previously, dorimedini-starkware wrote…

because I'm prepping for this to be merged first

And actually, I just assumed sequential is fine. Where can I see the actual builtin cost buffer values?

[orizi]

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dorimedini-starkware)

---

crates/cairo-lang-sierra/src/extensions/modules/builtin_cost.rs line 49 at r1 (raw file):

Previously, dorimedini-starkware wrote…

And actually, I just assumed sequential is fine. Where can I see the actual builtin cost buffer values?

It will be created in the OS, so this is fine

---

crates/cairo-lang-starknet/src/db.rs line 19 at r1 (raw file):

Previously, dorimedini-starkware wrote…

Done. Where can I see the correct order?

In the OS and in lamdaclass code

[dorimedini-starkware]

Reviewable status: 9 of 13 files reviewed, 1 unresolved discussion (waiting on @orizi)

---

crates/cairo-lang-starknet/src/db.rs line 19 at r1 (raw file):

Previously, orizi wrote…

In the OS and in lamdaclass code

Done.

[orizi]

Reviewed 4 of 4 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

[orizi]

Reviewed 3 of 3 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)