Search asdf directories for scarb executable

[szymmis]

Sometimes due to specific setup (like having custom ASDF_DATA_DIR variable) asdf scarb shim might not available through PATH variable. To solve this problem we can look for the executable in asdf directories as a fallback. Concept based on what intellij does when looking for java.

Worth noting that asdf is not supported on Windows machines outside WSL so when win32 platform is detected we just return undefined.

---

This change is 

[mkaput]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @spapinistarkware and @szymmis)

---

vscode-cairo/src/extension.ts line 111 at r1 (raw file):

  if (os.platform() === "win32") return undefined;

  const asdfDataDir = process.env.ASDF_DATA_DIR ?? `${process.env.HOME}/.asdf`;

• I think I'd bail out (return undefined from this function) if HOME is empty

Suggestion:

path.join(process.env.HOME, ".asdf")

---

vscode-cairo/src/extension.ts line 117 at r1 (raw file):

    .access(scarbExecutablePath, fs.constants.X_OK)
    .then(() => scarbExecutablePath)
    .catch(() => undefined);

Nit

Suggestion:

  try {
    return await fs.promises.access(scarbExecutablePath, fs.constants.X_OK);
  } catch _e {
    return undefined;
  }

[mkaput]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @spapinistarkware)

[spapinistarkware]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @szymmis)

[orizi]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @szymmis)