Made error message for entry point be dependent on failing var.

[orizi]

This change is 

[ilyalesokhin-starkware]

crates/cairo-lang-starknet/src/plugin/entry_point.rs line 95 at r1 (raw file):

            });
        }
        let mut input_data_short_err = format!("`{param_name}` failed to deserialize");

I see that this is not a regression compared to the current state,
but I'm not sure I like having all those constants in the byecode.

Suggestion:

"failed to deserialize `{param_name}`"

[orizi]

Reviewable status: 0 of 23 files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware)

---

crates/cairo-lang-starknet/src/plugin/entry_point.rs line 95 at r1 (raw file):

Previously, ilyalesokhin-starkware wrote…

I see that this is not a regression compared to the current state,
but I'm not sure I like having all those constants in the byecode.

i think i prefer having the param name more than the prefix.

the current one was very confusing - we may add "non-provable" info at some point of the future.

[ilyalesokhin-starkware]

crates/cairo-lang-starknet/src/plugin/entry_point.rs line 95 at r1 (raw file):

Previously, orizi wrote…

i think i prefer having the param name more than the prefix.

the current one was very confusing - we may add "non-provable" info at some point of the future.

"i think i prefer having the param name more than the prefix."
What is the prefix?

[orizi]

Reviewable status: 0 of 23 files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware)

---

crates/cairo-lang-starknet/src/plugin/entry_point.rs line 95 at r1 (raw file):

Previously, ilyalesokhin-starkware wrote…

"i think i prefer having the param name more than the prefix."
What is the prefix?

i meant before the other part.
I'd rather have:
'long_long_long_name' failed to des
than
failed to deserialize 'long_long_long

[ilyalesokhin-starkware]

crates/cairo-lang-starknet/src/plugin/entry_point.rs line 95 at r1 (raw file):

Previously, orizi wrote…

i meant before the other part.
I'd rather have:
'long_long_long_name' failed to des
than
failed to deserialize 'long_long_long

Ok, I wasn't sure if the former is correct grammatically.

[ilyalesokhin-starkware]

crates/cairo-lang-starknet/src/plugin/plugin_test_data/l1_handler line 205 at r1 (raw file):

            
            let __arg_from_address =
                serde::Serde::<u128>::deserialize(ref data).expect('`from_address` failed to deseri');

This is starnge.

Code quote:

'`from_address` failed to deseri'

[ilyalesokhin-starkware]

Reviewed 3 of 23 files at r1.
Reviewable status: 3 of 23 files reviewed, all discussions resolved

[ilyalesokhin-starkware]

crates/cairo-lang-starknet/src/plugin/entry_point.rs line 95 at r1 (raw file):

Previously, ilyalesokhin-starkware wrote…

Ok, I wasn't sure if the former is correct grammatically.

Maybe you should just give the index of the parameter?

[orizi]

Reviewable status: 3 of 23 files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)

---

crates/cairo-lang-starknet/src/plugin/plugin_test_data/l1_handler line 205 at r1 (raw file):

Previously, ilyalesokhin-starkware wrote…

This is starnge.

until we have normal long-string byte arrays - this would still be the easiest way to go.

[ilyalesokhin-starkware]

crates/cairo-lang-starknet/src/plugin/plugin_test_data/l1_handler line 205 at r1 (raw file):

Previously, orizi wrote…

until we have normal long-string byte arrays - this would still be the easiest way to go.

not doing this PR is even easier.

[ilyalesokhin-starkware]

Reviewed 20 of 23 files at r1.
Reviewable status: 22 of 23 files reviewed, all discussions resolved (waiting on @orizi)

[orizi]

Reviewable status: 22 of 23 files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)

---

crates/cairo-lang-starknet/src/plugin/entry_point.rs line 95 at r1 (raw file):

Previously, ilyalesokhin-starkware wrote…

Maybe you should just give the index of the parameter?

i don't really like that idea, but can do - still an improvement i guess.