Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid error propagation inside a loop. #3773

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

gilbens-starkware
Copy link
Contributor

@gilbens-starkware gilbens-starkware commented Jul 25, 2023

This change is Reviewable

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @spapinistarkware)

@orizi orizi linked an issue Jul 25, 2023 that may be closed by this pull request
@gilbens-starkware gilbens-starkware added this pull request to the merge queue Jul 26, 2023
Merged via the queue into main with commit 25ef1a5 Jul 26, 2023
38 checks passed
@orizi orizi deleted the gil/loop_question_mark branch August 10, 2023 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: non-descriptive compilation error when using ? operator in loop
2 participants