-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added line number to sierra printing. #3902
Conversation
commit-id:4fa9adf9
65f4cc1
to
d82c82f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 63 files at r1.
Reviewable status: 3 of 63 files reviewed, 1 unresolved discussion (waiting on @orizi)
crates/cairo-lang-sierra/src/fmt.rs
line 26 at r1 (raw file):
writeln!(f)?; for (i, statement) in self.statements.iter().enumerate() { writeln!(f, "{statement}; // {i}")?;
Can we do the following:
Suggestion:
writeln!(f, "{i}: {statement};")?;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 3 of 63 files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware)
crates/cairo-lang-sierra/src/fmt.rs
line 26 at r1 (raw file):
Previously, ilyalesokhin-starkware wrote…
Can we do the following:
No, as it won't be parsable by the parser. So it has to be a comment.
Previously, orizi wrote…
you could fix the parser... but I guess we might have backward compatibility issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 60 of 63 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware)
crates/cairo-lang-sierra/src/fmt.rs
line 26 at r1 (raw file):
Previously, ilyalesokhin-starkware wrote…
you could fix the parser...
but I guess we might have backward compatibility issues.
Exactly.
This change is