Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added line number to sierra printing. #3902

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented Aug 15, 2023

This change is Reviewable

@orizi orizi force-pushed the pr/orizi/orizi/auditors-imps/4fa9adf9 branch from 65f4cc1 to d82c82f Compare August 15, 2023 08:01
Copy link
Contributor

@ilyalesokhin-starkware ilyalesokhin-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 63 files at r1.
Reviewable status: 3 of 63 files reviewed, 1 unresolved discussion (waiting on @orizi)


crates/cairo-lang-sierra/src/fmt.rs line 26 at r1 (raw file):

        writeln!(f)?;
        for (i, statement) in self.statements.iter().enumerate() {
            writeln!(f, "{statement}; // {i}")?;

Can we do the following:

Suggestion:

writeln!(f, "{i}: {statement};")?;

Copy link
Collaborator Author

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 3 of 63 files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware)


crates/cairo-lang-sierra/src/fmt.rs line 26 at r1 (raw file):

Previously, ilyalesokhin-starkware wrote…

Can we do the following:

No, as it won't be parsable by the parser. So it has to be a comment.

@ilyalesokhin-starkware
Copy link
Contributor

crates/cairo-lang-sierra/src/fmt.rs line 26 at r1 (raw file):

Previously, orizi wrote…

No, as it won't be parsable by the parser. So it has to be a comment.

you could fix the parser...

but I guess we might have backward compatibility issues.

Copy link
Contributor

@ilyalesokhin-starkware ilyalesokhin-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 60 of 63 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi)

@orizi orizi added this pull request to the merge queue Aug 15, 2023
Copy link
Collaborator Author

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware)


crates/cairo-lang-sierra/src/fmt.rs line 26 at r1 (raw file):

Previously, ilyalesokhin-starkware wrote…

you could fix the parser...

but I guess we might have backward compatibility issues.

Exactly.

Merged via the queue into main with commit 6db827b Aug 15, 2023
37 of 38 checks passed
@orizi orizi deleted the pr/orizi/orizi/auditors-imps/4fa9adf9 branch August 15, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants