Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LS: Properly handle client notifications in E2E tests #5531

Merged
merged 1 commit into from
May 9, 2024
Merged

LS: Properly handle client notifications in E2E tests #5531

merged 1 commit into from
May 9, 2024

Conversation

mkaput
Copy link
Contributor

@mkaput mkaput commented May 9, 2024 •
edited by spapinistarkware
Loading

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

This change is Reviewable

This was referenced May 9, 2024
Closed
Closed
@mkaput mkaput requested a review from orizi May 9, 2024 12:57
orizi
orizi approved these changes May 9, 2024
View reviewed changes
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mkaput)

@mkaput mkaput added this pull request to the merge queue May 9, 2024
Merged via the queue into main with commit 6ee23d6 May 9, 2024
85 checks passed
@mkaput mkaput deleted the spr/main/0213b774 branch May 9, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orizi orizi orizi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mkaput @orizi