Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO #5880

Conversation

liorgold2
Copy link
Collaborator

@liorgold2 liorgold2 commented Jun 25, 2024

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.


This change is Reviewable

@liorgold2 liorgold2 force-pushed the pr/liorgold2/lior/audit16/e5566b34 branch from 6b05f44 to c99d6fd Compare June 25, 2024 14:17
@liorgold2 liorgold2 force-pushed the pr/liorgold2/lior/audit16/9acb216d branch 2 times, most recently from 6b050a6 to ed6d3bf Compare June 25, 2024 19:35
@liorgold2 liorgold2 force-pushed the pr/liorgold2/lior/audit16/e5566b34 branch from c99d6fd to e95899a Compare June 25, 2024 19:35
commit-id:e5566b34
@liorgold2 liorgold2 force-pushed the pr/liorgold2/lior/audit16/9acb216d branch from ed6d3bf to 202372f Compare June 25, 2024 19:59
@liorgold2 liorgold2 force-pushed the pr/liorgold2/lior/audit16/e5566b34 branch from e95899a to e587a0c Compare June 25, 2024 19:59
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @liorgold2)


crates/cairo-lang-sierra/src/extensions/modules/circuit.rs line 581 at r1 (raw file):

    type Concrete = ConcreteU96LimbsLessThanGuarantee;
    // Shortened name to fit in the 23 bytes limit.
    // TODO: Rename to U96LimbsLtGuarantee (small `t`).

Done.

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 4 files reviewed, 5 unresolved discussions (waiting on @liorgold2)


crates/cairo-lang-sierra/src/extensions/modules/circuit.rs line 944 at r1 (raw file):

                    vars: vec![
                        OutputVarInfo::new_builtin(add_mod_builtin_ty.clone(), 0),
                        // TODO: `new_builtin` uses `AddConst`.

Done.


crates/cairo-lang-sierra/src/extensions/modules/circuit.rs line 961 at r1 (raw file):

                    vars: vec![
                        OutputVarInfo::new_builtin(add_mod_builtin_ty, 0),
                        // TODO: `new_builtin` uses `AddConst`.

Done.


crates/cairo-lang-sierra/src/extensions/modules/circuit.rs line 1047 at r1 (raw file):

    ) -> Result<LibfuncSignature, SpecializationError> {
        let (circ_ty, _output_ty) = args_as_two_types(args)?;
        // TODO: check that `output_ty` is a valid output type.

Done.


crates/cairo-lang-sierra/src/extensions/modules/circuit.rs line 1108 at r1 (raw file):

        let one = bounded_int_ty(context, BigInt::one(), BigInt::one())?;

        // TODO: Use `new_builtin()` for the builtins.

@ilyalesokhin-starkware - I don't see this fix.

@orizi orizi deleted the branch pr/liorgold2/lior/audit16/9acb216d July 1, 2024 10:42
@orizi orizi closed this Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants