Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sync with verification #1964

Closed
wants to merge 5 commits into from
Closed

Conversation

yair-starkware
Copy link
Collaborator

@yair-starkware yair-starkware commented May 6, 2024

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information


This change is Reviewable

@yair-starkware yair-starkware self-assigned this May 6, 2024
Copy link

codecov bot commented May 6, 2024

Codecov Report

Attention: Patch coverage is 42.71457% with 287 lines in your changes missing coverage. Please review.

Project coverage is 74.09%. Comparing base (d224d59) to head (9bb5f03).
Report is 104 commits behind head on main.

Files Patch % Lines
crates/papyrus_sync/src/lib.rs 16.12% 130 Missing ⚠️
crates/papyrus_sync/src/verification.rs 9.83% 110 Missing ⚠️
crates/papyrus_common/src/class_hash.rs 77.88% 29 Missing and 17 partials ⚠️
crates/papyrus_common/src/block_hash.rs 93.75% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1964      +/-   ##
==========================================
- Coverage   74.95%   74.09%   -0.87%     
==========================================
  Files         126      127       +1     
  Lines       15938    16385     +447     
  Branches    15938    16385     +447     
==========================================
+ Hits        11947    12141     +194     
- Misses       2680     2919     +239     
- Partials     1311     1325      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yair-starkware yair-starkware force-pushed the yair/sync_with_verification branch 2 times, most recently from df9f417 to 631084b Compare May 6, 2024 10:34
Copy link

github-actions bot commented Jun 7, 2024

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale.
This PR will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions bot added the stale No activity for quite some time. label Jun 7, 2024
@github-actions github-actions bot closed this Jun 15, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jun 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
stale No activity for quite some time.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant