chore(network): unite Data with SignedBlockHeader

[ShahakShama]

This change is 

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.06%. Comparing base (06e7fd1) to head (306c685).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2041      +/-   ##
==========================================
+ Coverage   71.03%   71.06%   +0.02%     
==========================================
  Files         129      129              
  Lines       16885    16863      -22     
  Branches    16885    16863      -22     
==========================================
- Hits        11995    11983      -12     
+ Misses       3551     3542       -9     
+ Partials     1339     1338       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ShahakShama]

Reviewable status: 0 of 9 files reviewed, all discussions resolved (waiting on @DvirYo-starkware and @matan-starkware)

---

crates/papyrus_network/src/converters/test.rs line 0 at r1 (raw file):
Moved to crates/papyrus_network/src/converters/protobuf_conversion/header_test.rs

[matan-starkware]

Reviewed 8 of 9 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @DvirYo-starkware and @ShahakShama)

---

crates/papyrus_network/src/converters/protobuf_conversion/header.rs line 270 at r2 (raw file):

}

impl From<Option<SignedBlockHeader>> for protobuf::BlockHeadersResponse {

So if I understand all the deletions below, we previously were using an internal type Data in parallel to the external type BlockHeadersResponse which represented some things which don't belong in the proto BlockHeadersResponse. This change semantically aligned the internal type with the external type so we only hold header relevant information?

Code quote:

impl From<Option<SignedBlockHeader>> for protobuf::BlockHeadersResponse

---

crates/papyrus_network/src/network_manager/test.rs line 152 at r2 (raw file):

                }
                None => (Data::Fin(DataType::SignedBlockHeader), true),
            };

I find it more readable to break into multiple lines

Suggestion:

        let decoded_data = protobuf::BlockHeadersResponse::decode_length_delimited(&data[..])
            .unwrap()
            .try_into()
            .unwrap();
        let (data, is_fin) = match decoded_data {
            Some(signed_block_header) => {
                (Data::BlockHeaderAndSignature(signed_block_header), false)
            }
            None => (Data::Fin(DataType::SignedBlockHeader), true),
        };