Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: polyfill node core modules #16

Merged
merged 10 commits into from
Aug 14, 2023
Merged

feat: polyfill node core modules #16

merged 10 commits into from
Aug 14, 2023

Conversation

dan-ziv
Copy link
Collaborator

@dan-ziv dan-ziv commented Aug 13, 2023

Description of the Changes

Use webpack 5 to polyfill node core modules on browser env.

Check List

  • Changes have been done against master branch, and PR does not conflict
  • New unit / functional tests have been added (whenever applicable)
  • Test are passing in local environment
  • Docs have been updated
  • PR title is follow the convention: <type>[optional scope]: <description>, e.g: fix: minor typos in code

"main": "dist/src/js/index.js",
"types": "dist/src/js/index.d.ts",
"main": "dist/index.js",
"types": "dist/types/src/js/index.d.ts",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe it's worth moving the types to dist/types/index.d.ts or dist/index.d.ts, without the src/js, but not critical.

@dan-ziv dan-ziv changed the title fix: polyfill node core modules feat: polyfill node core modules Aug 14, 2023
@dan-ziv dan-ziv merged commit ee6290c into dev Aug 14, 2023
2 checks passed
@dan-ziv dan-ziv deleted the polyfill-node-core-modules branch August 14, 2023 10:08
dan-ziv pushed a commit that referenced this pull request Aug 14, 2023
 ## [0.2.0-dev.1](v0.1.1-dev.2...v0.2.0-dev.1) (2023-08-14)

### 🧩 Features

* polyfill node core modules ([#16](#16)) ([ee6290c](ee6290c))
@dan-ziv
Copy link
Collaborator Author

dan-ziv commented Aug 14, 2023

🎉 This PR is included in version 0.2.0-dev.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

dan-ziv pushed a commit that referenced this pull request Aug 14, 2023
 ## [0.2.0](v0.1.0...v0.2.0) (2023-08-14)

### 📚 Docs

* fixed URL to Pedersen hash documentation ([#15](#15)) ([23f09b4](23f09b4))

### 🔧 Fixes

* use ESM export from index file ([01e5c58](01e5c58))

### 🧩 Features

* polyfill node core modules ([#16](#16)) ([ee6290c](ee6290c))
@dan-ziv
Copy link
Collaborator Author

dan-ziv commented Aug 14, 2023

🎉 This PR is included in version 0.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants