Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract constraint code into functions. #644

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

alonh5
Copy link
Contributor

@alonh5 alonh5 commented May 27, 2024

This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.50%. Comparing base (3150e16) to head (eb83ad6).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #644   +/-   ##
=======================================
  Coverage   89.50%   89.50%           
=======================================
  Files          75       75           
  Lines        9640     9640           
  Branches     9640     9640           
=======================================
  Hits         8628     8628           
  Misses        932      932           
  Partials       80       80           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alonh5 alonh5 force-pushed the 05-27-extract_constraint_code_into_functions branch 3 times, most recently from 994859e to cf74d9b Compare May 27, 2024 12:50
@alonh5 alonh5 force-pushed the 05-26-use_securefield_in_interaction branch from f54597b to f478872 Compare May 28, 2024 12:14
@alonh5 alonh5 force-pushed the 05-27-extract_constraint_code_into_functions branch from cf74d9b to f1cf98b Compare May 28, 2024 12:14
@alonh5 alonh5 force-pushed the 05-26-use_securefield_in_interaction branch from f478872 to 2745ab2 Compare May 28, 2024 12:51
@alonh5 alonh5 force-pushed the 05-27-extract_constraint_code_into_functions branch from f1cf98b to 95c0db7 Compare May 28, 2024 12:52
@alonh5 alonh5 force-pushed the 05-26-use_securefield_in_interaction branch from 2745ab2 to 2b5645b Compare May 29, 2024 07:48
@alonh5 alonh5 force-pushed the 05-27-extract_constraint_code_into_functions branch from 95c0db7 to 32c879a Compare May 29, 2024 07:48
@alonh5 alonh5 force-pushed the 05-26-use_securefield_in_interaction branch from 2b5645b to e0a1eb6 Compare May 29, 2024 12:55
@alonh5 alonh5 force-pushed the 05-27-extract_constraint_code_into_functions branch from 32c879a to 77a2633 Compare May 29, 2024 12:55
@alonh5 alonh5 force-pushed the 05-26-use_securefield_in_interaction branch from e0a1eb6 to ddf2647 Compare May 30, 2024 13:36
@alonh5 alonh5 force-pushed the 05-27-extract_constraint_code_into_functions branch from 77a2633 to ec3289d Compare May 30, 2024 13:37
@alonh5 alonh5 force-pushed the 05-26-use_securefield_in_interaction branch from ddf2647 to c1d309c Compare June 2, 2024 08:54
@alonh5 alonh5 force-pushed the 05-27-extract_constraint_code_into_functions branch from ec3289d to 9bc5a9c Compare June 2, 2024 08:54
@alonh5 alonh5 force-pushed the 05-26-use_securefield_in_interaction branch from b4b6328 to ccd2fb8 Compare June 23, 2024 09:23
@alonh5 alonh5 force-pushed the 05-27-extract_constraint_code_into_functions branch from 33a171b to c1fe76e Compare June 23, 2024 09:23
@alonh5 alonh5 force-pushed the 05-26-use_securefield_in_interaction branch from ccd2fb8 to 88b9ad2 Compare June 23, 2024 10:20
@alonh5 alonh5 force-pushed the 05-27-extract_constraint_code_into_functions branch from c1fe76e to 686e540 Compare June 23, 2024 10:20
@alonh5 alonh5 force-pushed the 05-26-use_securefield_in_interaction branch from 88b9ad2 to 0dcbd87 Compare June 23, 2024 10:57
@alonh5 alonh5 force-pushed the 05-27-extract_constraint_code_into_functions branch from 686e540 to a31d008 Compare June 23, 2024 10:58
@alonh5 alonh5 force-pushed the 05-26-use_securefield_in_interaction branch from 0dcbd87 to de6e3a6 Compare June 23, 2024 13:02
@alonh5 alonh5 force-pushed the 05-27-extract_constraint_code_into_functions branch from a31d008 to 2fc8333 Compare June 23, 2024 13:02
@alonh5 alonh5 force-pushed the 05-26-use_securefield_in_interaction branch from de6e3a6 to 88f8a6d Compare June 23, 2024 13:20
@alonh5 alonh5 force-pushed the 05-27-extract_constraint_code_into_functions branch from 2fc8333 to 0717240 Compare June 23, 2024 13:20
@alonh5 alonh5 force-pushed the 05-26-use_securefield_in_interaction branch from 88f8a6d to c6aaf57 Compare June 23, 2024 13:34
@alonh5 alonh5 force-pushed the 05-27-extract_constraint_code_into_functions branch from 0717240 to f631952 Compare June 23, 2024 13:34
@alonh5 alonh5 force-pushed the 05-26-use_securefield_in_interaction branch from c6aaf57 to 6a16e22 Compare June 24, 2024 10:02
@alonh5 alonh5 force-pushed the 05-27-extract_constraint_code_into_functions branch from f631952 to c6d22b6 Compare June 24, 2024 10:02
@alonh5 alonh5 force-pushed the 05-26-use_securefield_in_interaction branch from 6a16e22 to 96ac8ba Compare June 26, 2024 10:23
@alonh5 alonh5 force-pushed the 05-27-extract_constraint_code_into_functions branch from c6d22b6 to 59f6ca2 Compare June 26, 2024 10:23
@alonh5 alonh5 force-pushed the 05-26-use_securefield_in_interaction branch from 96ac8ba to 34a1233 Compare June 27, 2024 10:56
@alonh5 alonh5 force-pushed the 05-27-extract_constraint_code_into_functions branch from 59f6ca2 to a9b0e6f Compare June 27, 2024 10:56
Copy link
Contributor Author

alonh5 commented Jun 27, 2024

Merge activity

  • Jun 27, 8:38 AM EDT: @alonh5 started a stack merge that includes this pull request via Graphite.
  • Jun 27, 8:41 AM EDT: Graphite rebased this pull request as part of a merge.
  • Jun 27, 8:44 AM EDT: @alonh5 merged this pull request with Graphite.

@alonh5 alonh5 changed the base branch from 05-26-use_securefield_in_interaction to dev June 27, 2024 12:39
@alonh5 alonh5 force-pushed the 05-27-extract_constraint_code_into_functions branch from a9b0e6f to eb83ad6 Compare June 27, 2024 12:40
@alonh5 alonh5 merged commit de9892b into dev Jun 27, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants