Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store new user's password in keyring for Distributed Cloud #4

Merged
merged 1 commit into from
Oct 17, 2018

Conversation

andy-ning
Copy link
Contributor

In Distributed Cloud when audit tries to create a user missing in subcloud,
the user's password is needed. But keystone API never returns password, so
the password has to be stored in keyring and retrieved from keyring when
needed.

Note that this is a temporary solution for users synchronization in DC.
Once the new synchronization mechanism from Story 2002842 is in place,
we will revisit this change.

Closes-Bug: 1797970

@andy-ning
Copy link
Contributor Author

"Remove embedded keystone policy config change" has been merged a while ago.
"Merge pull request #1 from starlingx-staging/master" came from update my forked repo to stx master repo.

I'm not able to remove them from the pull request, maybe because the commits id changed. Please let me know if this is a problem and I'll create a new pull request.

Copy link

@tliu88 tliu88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good.

In Distributed Cloud when audit tries to create a user missing in subcloud,
the user's password is needed. But keystone API never returns password, so
the password has to be stored in keyring and retrieved from keyring when
needed.

Note that this is a temporary solution for users synchronization in DC.
Once the new synchronization mechanism from Story 2002842 is in place,
we will revisit this change.

Closes-Bug: 1797970

Signed-off-by: Andy Ning <andy.ning@windriver.com>
@andy-ning
Copy link
Contributor Author

The pull request has now been updated to have only one commit. This is done by a force push from my local repo that is synced with keystone master repo at stx-staging.

@brent-rowsell brent-rowsell merged commit 2c3dc78 into starlingx-staging:master Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants