Fix configurable pci bus slots for PCI passthrough vnics #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 7020c70 ported an internal commit for allowing configurable PCI bus slots for vnics, but did not include a subsequent internal commit that removed the modifications to _guest_add_pci_devices. As such, the commit relies on an obsolete PciDevice object, which causes an exception to occur in stx-nova for any instance trying to boot with PCI passthrough vnics. In fact, we can return _guest_add_pci_devices to it's upstream signature and behaviour, as the configurable address is set in the general _get_guest_config function. Testing: - Launched instances with PCI passthrough vnics. Ensured vif PCI address could be set via the boot command. - Tox Story: 2002877 Task: 22839 Closes-Bug: #1796952 Closes-Bug: #1796198
|
LGTM |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 7020c70 ported an internal commit for allowing configurable
PCI bus slots for vnics, but did not include a subsequent internal
commit that removed the modifications to _guest_add_pci_devices.
As such, the commit relies on an obsolete PciDevice object, which
causes an exception to occur in stx-nova for any instance trying
to boot with PCI passthrough vnics.
In fact, we can return _guest_add_pci_devices to it's upstream
signature and behaviour, as the configurable address is set in
the general _get_guest_config function.
Testing:
vif PCI address could be set via the boot command.
Story: 2002877
Task: 22839
Closes-Bug: #1796952
Closes-Bug: #1796198