-
-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update __init__ return typing to be consistent #506
Conversation
Ok, if we want to go this path we should actually use the |
Mypy doesn't let you do that:
Seems
Some refs: |
Aight |
I added return type because initializer of MakoTemplateEngine class have None as an return type. It is for the constancy. |
@Harshal6927 why don't we broaden this PR out and annotate the return for all |
Should I do it? |
I think so, best to be consistent. And pep recommended:
|
@peterschutt Ok I'll update my PR. |
You missed a few e.g.
...etc (there are quite a few more) |
@all-contributors add @Harshal6927 code |
I've put up a pull request to add @Harshal6927! 🎉 |
* Added return type for initializer of DTOFactory class * Added return type for initializer * code formatted correctly and ci.yaml changes * Added return type for initializer
PR Checklist
CONTRIBUTING.md
?