-
-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
671 enhancment replace starlettes staticfiles with our own implementation #739
671 enhancment replace starlettes staticfiles with our own implementation #739
Conversation
This pull request introduces 3 alerts when merging 118b4d5 into 34740bd - view on LGTM.com new alerts:
|
I'm not so sure about the hard dependency on
|
118b4d5
to
2eafc9c
Compare
This pull request introduces 3 alerts when merging 2eafc9c into 05c0db4 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 075f924 into 05c0db4 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging b6d4b9c into 28ddc84 - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the fairly superficial review, I'm not active in this space so will rely on others to weigh in on the technical details.
Cheers!
ETA: one other thing that stood out was that sometimes we use FS
and others FileSystem
, e.g., fs.py
, FSInfo
, FileSystemAdapter
, BaseLocalFileSystem
. You've highlighted your disdain for abbreviations to me before, but also I understand that fs
is a fairly ubiquitous/unambiguous abbr, so just thought I'd mention, but happy to go with what you have if everyone happy with it.
Also, made that commit for the typo as that line wasn't available for a suggestion, so figured I'd just sneak the fix in with this PR.
Co-authored-by: Peter Schutt <peter@topsport.com.au>
Co-authored-by: Peter Schutt <peter@topsport.com.au>
Co-authored-by: Peter Schutt <peter@topsport.com.au>
Co-authored-by: Peter Schutt <peter@topsport.com.au>
Co-authored-by: Peter Schutt <peter@topsport.com.au>
Co-authored-by: Peter Schutt <peter@topsport.com.au>
Co-authored-by: Peter Schutt <peter@topsport.com.au>
Co-authored-by: Peter Schutt <peter@topsport.com.au>
…s-with-our-own-implementation
This pull request introduces 1 alert when merging 1b1c811 into 28ddc84 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 4444b69 into 28ddc84 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging f7f2a56 into 28ddc84 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging d5641a8 into 28ddc84 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging dfaff3f into 3ee86e9 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 6e12d21 into 3ee86e9 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 1eaadef into 3ee86e9 - view on LGTM.com new alerts:
|
…s-with-our-own-implementation
This pull request introduces 1 alert when merging 4379747 into 3ee86e9 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 9feff05 into 3ee86e9 - view on LGTM.com new alerts:
|
Kudos, SonarCloud Quality Gate passed! |
This pull request introduces 1 alert when merging 2cfb02a into 3ee86e9 - view on LGTM.com new alerts:
|
Fix for vulnerability introduced in #739, caused by failure to normalize the path part extracted from URL before serving data from a static directory. See GHSA-83pv-qr33-2vcf for specific details. Co-authored-by: Jacob Coffee <jacob@z7x.org> Co-authored-by: Brian Edgar Ré <brian@192.168.1.4>
Fix for vulnerability introduced in #739, caused by failure to normalize the path part extracted from URL before serving data from a static directory. See GHSA-83pv-qr33-2vcf for specific details. Co-authored-by: Jacob Coffee <jacob@z7x.org> Co-authored-by: Brian Edgar Ré <brian@192.168.1.4>
Fix for vulnerability introduced in #739, caused by failure to normalize the path part extracted from URL before serving data from a static directory. See GHSA-83pv-qr33-2vcf for specific details. Co-authored-by: Brian Edgar Ré <brian@192.168.1.4> Co-authored-by: Peter Schutt <peter.github@proton.me>
Fix for vulnerability introduced in #739, caused by failure to normalize the path part extracted from URL before serving data from a static directory. See GHSA-83pv-qr33-2vcf for specific details. Co-authored-by: Brian Edgar Ré <brian@192.168.1.4> Co-authored-by: Peter Schutt <peter.github@proton.me>
Fix for vulnerability introduced in #739, caused by failure to normalize the path part extracted from URL before serving data from a static directory. See GHSA-83pv-qr33-2vcf for specific details. Co-authored-by: Brian Edgar Ré <brian@192.168.1.4> Co-authored-by: Peter Schutt <peter.github@proton.me>
* fix: pass branch to `create_draft_release()` * Merge pull request from GHSA-83pv-qr33-2vcf Fix for vulnerability introduced in #739, caused by failure to normalize the path part extracted from URL before serving data from a static directory. See GHSA-83pv-qr33-2vcf for specific details. Co-authored-by: Brian Edgar Ré <brian@192.168.1.4> Co-authored-by: Peter Schutt <peter.github@proton.me> * chore(release): prepare release v2.8.3 --------- Co-authored-by: Jacob Coffee <jacob@z7x.org> Co-authored-by: Brian Edgar Ré <brian@192.168.1.4>
PR Checklist
CONTRIBUTING.md
?