Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug while preprocessing #1

Closed
XavierIsabel opened this issue Sep 11, 2023 · 2 comments
Closed

Bug while preprocessing #1

XavierIsabel opened this issue Sep 11, 2023 · 2 comments

Comments

@XavierIsabel
Copy link

Hi! I am trying to reproduce the results shown in your article. While preprocessing the datasets, I am encountering multiple problems and bugs. Would their be any commits that haven't been made? A bug example is "preprocess_run.sh" calling the line "python main_setp1.py [...] ;" instead of "python main_step1.py [...] ;". Another one is the fact that the preprocess doesn't seem to consider the latest versions of the datasets.
Thank you!

@starmpcc
Copy link
Owner

starmpcc commented Sep 12, 2023

Sorry, we noticed that our last bug fix commit was lost.
I will create the bug fix again within this week as soon as possible.
Related to the dataset version, please consider using MIMIC-IV 1.0.

FYI: There are a few imprecise logic sequences in the pre-processing codes, so we have migrated to integrated-ehr-pipeline for our current work.

Thank you for your interest in our work!

@starmpcc
Copy link
Owner

starmpcc commented Sep 17, 2023

It's nearing completion, and it currently supports MIMIC-IV 2.0.
Unfortunately, my local server is under maintenance, so I'm unable to perform an end-to-end check at the moment.
I believe everything should work properly, but I'll test it all tomorrow and finalize it.

Update: I verified it finally works! If you have any problem, feel free to ask me!

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants