#120 - Added test case

starnowski · Apr 10, 2024 · 5a66d36 · 5a66d36
1 parent f3f1a96
commit 5a66d36
Show file tree

Hide file tree

Showing 3 changed files with 33 additions and 2 deletions.
diff --git a/json-core/src/main/java/com/github/starnowski/posjsonhelper/json/core/sql/JsonTextArray.java b/json-core/src/main/java/com/github/starnowski/posjsonhelper/json/core/sql/JsonTextArray.java
@@ -3,6 +3,7 @@
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.List;
+import java.util.Objects;
 import java.util.stream.Collectors;
 
 public class JsonTextArray {
@@ -13,6 +14,19 @@ public JsonTextArray(List<Object> path) {
         this.path = path == null ? new ArrayList<>() : Collections.unmodifiableList(path);
     }
 
+    @Override
+    public boolean equals(Object o) {
+        if (this == o) return true;
+        if (o == null || getClass() != o.getClass()) return false;
+        JsonTextArray that = (JsonTextArray) o;
+        return Objects.equals(path, that.path);
+    }
+
+    @Override
+    public int hashCode() {
+        return Objects.hash(path);
+    }
+
     public List<Object> getPath() {
         return path;
     }

diff --git a/...ithub/starnowski/posjsonhelper/json/core/sql/JsonUpdateStatementConfigurationBuilder.java b/...ithub/starnowski/posjsonhelper/json/core/sql/JsonUpdateStatementConfigurationBuilder.java
@@ -22,8 +22,7 @@ public JsonUpdateStatementConfigurationBuilder withPostSortFilter(JsonUpdateStat
     }
 
     public JsonUpdateStatementConfigurationBuilder append(JsonUpdateStatementOperationType operation, JsonTextArray jsonTextArray, String value) {
-        operations.add(new JsonUpdateStatementConfiguration.JsonUpdateStatementOperation(jsonTextArray, operation, value));
-        return this;
+        return append(new JsonUpdateStatementConfiguration.JsonUpdateStatementOperation(jsonTextArray, operation, value));
     }
 
     public JsonUpdateStatementConfigurationBuilder append(JsonUpdateStatementConfiguration.JsonUpdateStatementOperation operation) {

diff --git a/...starnowski/posjsonhelper/json/core/sql/JsonUpdateStatementConfigurationBuilderTest.groovy b/...starnowski/posjsonhelper/json/core/sql/JsonUpdateStatementConfigurationBuilderTest.groovy
@@ -2,6 +2,8 @@ package com.github.starnowski.posjsonhelper.json.core.sql
 
 import spock.lang.Specification
 
+import static com.github.starnowski.posjsonhelper.json.core.sql.JsonUpdateStatementOperationType.JSONB_SET
+
 class JsonUpdateStatementConfigurationBuilderTest extends Specification {
 
     def "should build configuration based on components if component are defined"()
@@ -53,4 +55,20 @@ class JsonUpdateStatementConfigurationBuilderTest extends Specification {
             result
             result.getOperations() == [operation1, operation2, operation3, operation4]
     }
+
+    def "should build correct configuration"()
+    {
+        given:
+            def tested = new JsonUpdateStatementConfigurationBuilder()
+                    .append(JSONB_SET, (new JsonTextArrayBuilder()).append("parent").append("child1").build(), "some value1")
+                    .withPostSortFilter(null)
+                    .withSort(null)
+
+        when:
+            def result = tested.build()
+
+        then:
+            result
+            result.getOperations() == [new JsonUpdateStatementConfiguration.JsonUpdateStatementOperation((new JsonTextArrayBuilder()).append("parent").append("child1").build(), JSONB_SET, "some value1")]
+    }
 }