Skip to content

Commit

Permalink
fix(plugins/plugin-kubectl): regression in events drilldown
Browse files Browse the repository at this point in the history
Recently kubernetes-sigs#9001 added a resourceVersion join key to the events drilldown query. This PR switches us over to `uid`
  • Loading branch information
starpit committed Sep 3, 2022
1 parent e5339e4 commit 44f09b2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion plugins/plugin-kubectl/src/lib/view/modes/Events.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ function hasEvents(resource: KubeResource): boolean {
*/
function command(_, resource: KubeResource, args: { argvNoOptions: string[]; parsedOptions: ParsedOptions }) {
// limit events to those intersecting with the giving resource
const filter = `involvedObject.apiVersion=${resource.apiVersion},involvedObject.kind=${resource.kind},involvedObject.name=${resource.metadata.name},involvedObject.namespace=${resource.metadata.namespace},involvedObject.resourceVersion=${resource.metadata.resourceVersion}`
const filter = `involvedObject.apiVersion=${resource.apiVersion},involvedObject.kind=${resource.kind},involvedObject.name=${resource.metadata.name},involvedObject.namespace=${resource.metadata.namespace},involvedObject.uid=${resource.metadata.uid}`

// this is the command that will fetch the events table; we specify a watchable table
const argv = [
Expand Down

0 comments on commit 44f09b2

Please sign in to comment.