Skip to content

Commit

Permalink
perf(memory_usage): replace sysinfo with sys-info (#1886)
Browse files Browse the repository at this point in the history
* perf(memory_usage): replace sysinfo with sys-info

* format

* simplify error handling
  • Loading branch information
davidkna committed Nov 24, 2020
1 parent 688f1b3 commit 0f483fa
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 32 deletions.
30 changes: 5 additions & 25 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ unicode-segmentation = "1.7.0"
gethostname = "0.2.1"
once_cell = "1.5.2"
chrono = "0.4"
sysinfo = "0.15.3"
sys-info = "0.7.0"
byte-unit = "4.0.9"
starship_module_config_derive = { version = "0.1.2", path = "starship_module_config_derive" }
yaml-rust = "0.4"
Expand Down
23 changes: 17 additions & 6 deletions src/modules/memory_usage.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
use byte_unit::{Byte, ByteUnit};
use sysinfo::{RefreshKind, SystemExt};

use super::{Context, Module, RootModuleConfig, Shell};

Expand Down Expand Up @@ -39,9 +38,21 @@ pub fn module<'a>(context: &'a Context) -> Option<Module<'a>> {
return None;
}

let system = sysinfo::System::new_with_specifics(RefreshKind::new().with_memory());
let used_memory_kib = system.get_used_memory();
let total_memory_kib = system.get_total_memory();
let system = match sys_info::mem_info() {
Ok(info) => info,
Err(err) => {
log::warn!("Unable to access memory usage information:\n{}", err);
return None;
}
};

// avail includes reclaimable memory, but isn't supported on all platforms
let avail_memory_kib = match system.avail {
0 => system.free,
_ => system.avail,
};
let used_memory_kib = system.total - avail_memory_kib;
let total_memory_kib = system.total;
let ram_used = (used_memory_kib as f64 / total_memory_kib as f64) * 100.;
let ram_pct = format_pct(ram_used, pct_sign);

Expand All @@ -51,8 +62,8 @@ pub fn module<'a>(context: &'a Context) -> Option<Module<'a>> {
}

let ram = format_usage_total(used_memory_kib, total_memory_kib);
let total_swap_kib = system.get_total_swap();
let used_swap_kib = system.get_used_swap();
let total_swap_kib = system.swap_total;
let used_swap_kib = system.swap_total - system.swap_free;
let percent_swap_used = (used_swap_kib as f64 / total_swap_kib as f64) * 100.;
let swap_pct = format_pct(percent_swap_used, pct_sign);
let swap = format_usage_total(used_swap_kib, total_swap_kib);
Expand Down

0 comments on commit 0f483fa

Please sign in to comment.