Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Umbrella: Preparation for the release of format strings #1057

Closed
49 of 51 tasks
heyrict opened this issue Apr 7, 2020 · 8 comments · Fixed by #1374
Closed
49 of 51 tasks

Umbrella: Preparation for the release of format strings #1057

heyrict opened this issue Apr 7, 2020 · 8 comments · Fixed by #1374
Labels
✨ enhancement A new feature implementation. ☂️ umbrella An umbrella issue, typically a big issues which contains many smaller issues to tackle
Milestone

Comments

@heyrict
Copy link
Member

heyrict commented Apr 7, 2020

Related #624, #1021 (comment)

This is a tracking issue about thing to do after #1021 get merged.

@heyrict heyrict added the 💬 discussion Conversation to figure out actionable steps. Most feature ideas start here. label Apr 7, 2020
@matchai matchai changed the title Post refactoring after #1021 Umbrella: Preparation for the release of format strings Apr 8, 2020
@matchai
Copy link
Member

matchai commented Apr 8, 2020

Something we will need to address before making these breaking changes is a migration path. How will we inform users that their prompt configuration is no longer compatible, and how do we show them how to migrate from old configuration to the new format strings?

I've gone ahead and opened #1075, which would allow us to print a deprecation notice, and a link to a migration guide. In the meantime, I will write a migration guide to add to the Starship website.

@heyrict
Copy link
Member Author

heyrict commented Apr 9, 2020

What do you think about a migration script?
It seems to me that SegmentConfig can be easily converted to a []() format. Although this may change the style of the original config file, users don't have to spend extra time tuning their config.

@matchai
Copy link
Member

matchai commented Apr 9, 2020

You're right. A migration script would be the most painless solution and should be relatively easy to implement.

@andytom
Copy link
Member

andytom commented Apr 10, 2020

Should we add a task (or multiple tasks) to make sure we have updated the documentation, both for the individual modules and a general explanation for the format syntax?

@andytom
Copy link
Member

andytom commented Apr 17, 2020

There is a feature branch, feat/format-string, that contains all the WIP for this issue.

@tiffafoo tiffafoo added ☂️ umbrella An umbrella issue, typically a big issues which contains many smaller issues to tackle ✨ enhancement A new feature implementation. and removed 💬 discussion Conversation to figure out actionable steps. Most feature ideas start here. labels May 19, 2020
@tiffafoo tiffafoo modified the milestones: Format Strings Release, v1.0.0 May 19, 2020
@matchai
Copy link
Member

matchai commented May 19, 2020

Seeing as this is the biggest breaking change to Starship configuration in the foreseeable future, it's probably a good time to finally go v1.0.0. I kept waiting until the project felt a little more "stable", but I don't know that it'll be the case until a full rewrite (the work being done at https://github.com/matchai/starship-poc).
What are your thoughts?

@heyrict
Copy link
Member Author

heyrict commented May 20, 2020

Well, imho, before we can finally go to v1.0.0 release, we should at least address the long waiting time in git_status. It seems a bad choice to me if users still have to wait a long time in a large git repo in stable.

Adding man pages, or config wizards, or optionally packages for different distributions (deb, AUR, etc.) may also be considered before v1.0.0.

@matchai
Copy link
Member

matchai commented May 21, 2020

As much as I agree and would like to make a big deal of "V1 STABLE 🎉", being in v0.X.X gives users the impression that any update can be breaking. If we think that the big performance bottleneck of git_status is needed before v1, we could try to rush it in before we finish format strings. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement A new feature implementation. ☂️ umbrella An umbrella issue, typically a big issues which contains many smaller issues to tackle
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants