-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Umbrella: Preparation for the release of format strings #1057
Comments
Something we will need to address before making these breaking changes is a migration path. How will we inform users that their prompt configuration is no longer compatible, and how do we show them how to migrate from old configuration to the new format strings? I've gone ahead and opened #1075, which would allow us to print a deprecation notice, and a link to a migration guide. In the meantime, I will write a migration guide to add to the Starship website. |
What do you think about a migration script? |
You're right. A migration script would be the most painless solution and should be relatively easy to implement. |
Should we add a task (or multiple tasks) to make sure we have updated the documentation, both for the individual modules and a general explanation for the format syntax? |
There is a feature branch, |
Seeing as this is the biggest breaking change to Starship configuration in the foreseeable future, it's probably a good time to finally go |
Well, imho, before we can finally go to Adding man pages, or config wizards, or optionally packages for different distributions (deb, AUR, etc.) may also be considered before |
As much as I agree and would like to make a big deal of "V1 STABLE 🎉", being in v0.X.X gives users the impression that any update can be breaking. If we think that the big performance bottleneck of |
Related #624, #1021 (comment)
This is a tracking issue about thing to do after #1021 get merged.
Refactoring
prompt_order
inStarshipRootConfig
to use format string. (refactor: Replace prompt_order with format string #1056)Allow using variables in style string.
[>]($prompt_color bold)
(feat(format_string): Allow using variables in a style string #1130)(Needs discussion, as this may lead to unexpected behavior) Style overriding:Makerenders red boldtext1
and green boldtext2
Add to docs general explanations for format string (docs: Add docs for format strings #1083)
Add migration guide or script (Implement error messaging for the prompt #1075,
feat: Add migration script for format strings #1078, Create migration guide for the format string release #1404)Refactor modules and their docs to use format string
line_break- See refactor: Replace prompt_order with format string #1056Depracate
SegmentConfig
,Affix
,Suffix
,once all modules use the new format system. (chore: Deprecate affix and module style #1394)(Future) Adds a macro
format_string!
that converts&'static str
toVec<Segment<'static>>
at compile time.The text was updated successfully, but these errors were encountered: