docs: Add details about musl build to readme #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daniel15
changed the title
|
Thanks for the PR! I'm in favor of adding this info to the docs, but I think putting it in the main README is going to cause some headaches for poor matchai when he needs to refactor the README again to keep its length down (we've already had several rounds of that). Do you think this would be appropriate as a section in the FAQ instead? |
|
I think it'd be okay to just be on the website, however the installation instructions on the site seem to pull from the readme. |
|
I believe |
dagbrown
pushed a commit
to dagbrown/starship
that referenced
this pull request
Oct 22, 2021
* Add details about musl build to readme * Move details to FAQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added an explanation of the musl build to the readme, in case anyone else tries to use starship with CentOS 7
Motivation and Context
Just a documentation update.
References #342
Fixes #1052