Git status deleted and renamed show up for both changes in the working directory and in staging.

[philipbordallo]

Bug Report

Current Behavior

Git status deleted and renamed symbols show up for both changes in the working directory and for when a file is staged.

Expected Behavior

Git status deleted and renamed symbols show up for when a file is staged.

Additional context/Screenshots

In the documentation, deleted and renamed are both described as being related to when a file is in the staging area. But it looks like deleted and renamed symbols show up regardless of whether they are in staging or the working directory.

Here's an example, given this setup:

example-repo on  release 
❯ tree
.
├── one.txt
└── two.txt

0 directories, 2 files

If I delete one.txt, and rename two.txt to three.txt, I see the deleted and renamed symbols even though the files are part of the working directory.

example-repo on  release [✘»] 
❯ git status --long
On branch release
Changes not staged for commit:
  (use "git add/rm <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	deleted:    one.txt
	deleted:    two.txt

Untracked files:
  (use "git add <file>..." to include in what will be committed)
	three.txt

no changes added to commit (use "git add" and/or "git commit -a")

And adding them to staging, the symbols remain (matching what's stated in the documentation).

example-repo on  release [✘»] 
❯ git status --long
On branch release
Changes to be committed:
  (use "git restore --staged <file>..." to unstage)
	renamed:    one.txt -> three.txt
	deleted:    two.txt

Environment

• Starship version: starship 0.42.0
• Shell type: zsh
• Shell version: zsh 5.8
• Terminal emulator: Terminal.app
• Operating system: macOS 10.14.6

[Aelnor]

I can try to investigate this one unless someone objects.

[Aelnor]

Here's the investigation result.
This behavior is caused by renames_index_to_workdir() option (src/modules/git_status.rs:202)

I'm not sure if Starship needs it, but I've found out it was introduced here (which doesn't help either): https://github.com/starship/starship/pull/247/files