feat(utils): Support non-exe commands on Windows #2019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Have added support to the `utils::exec_cmd` to allow it to execute commands that are not `.exe` on Windows. Have also added a timer to measure how long a command took to execute.
davidkna
approved these changes
Dec 21, 2020
davidkna
reviewed
Dec 21, 2020
| @@ -243,14 +244,31 @@ pub fn wrap_seq_for_shell( | |||
|
|
|||
| fn internal_exec_cmd(cmd: &str, args: &[&str]) -> Option<CommandOutput> { | |||
| log::trace!("Executing command {:?} with args {:?}", cmd, args); | |||
| match Command::new(cmd).args(args).output() { | |||
|
|
|||
| let full_path = match which::which(cmd) { | |||
There was a problem hiding this comment.
It might be worth it to build a map of all the exetuables in the PATH in the future, to avoid having to walk the whole PATH on each invocation.
There was a problem hiding this comment.
I think that might be something to look at in the future or maybe something we can get added to the upstream library.
|
Thanks for the review @davidkna |
chipbuster
pushed a commit
to chipbuster/starship
that referenced
this pull request
Dec 31, 2020
Have added support to the `utils::exec_cmd` to allow it to execute commands that are not `.exe` on Windows. Have also added a timer to measure how long a command took to execute.
chipbuster
pushed a commit
to chipbuster/starship
that referenced
this pull request
Jan 14, 2021
Have added support to the `utils::exec_cmd` to allow it to execute commands that are not `.exe` on Windows. Have also added a timer to measure how long a command took to execute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Have added support to the
utils::exec_cmdto allow it to executecommands that are not
.exeon Windows. Have also added a timer tomeasure how long a command took to execute.
Motivation and Context
Closes #983
Closes #2018
Screenshots (if appropriate):
How Has This Been Tested?
Checklist: