Improve nodejs module detection

[kidonng]

Feature Request

Is your feature request related to a problem? Please describe.

#2565 added deno module, which checks for a {mod,deps}.{j,t}s file, while currently nodejs module checks for *.{j,t}s. This produces a awkward result:

As the screenshot shows, I'm inside a pure Deno project, but the unrelated Node version is shown.

---

Beside my original motivation of opening this issue, I'd like to point out .ts is the file extension for MPEG transport stream as well. This is also common, for example, Deno (coincidentally, this issue is also about Deno) encountered a outage last month due to Cloudflare considering .ts files MPEG transport stream.

So my wish is if possible, Starship can check if any of the .ts files is plain text before deciding to show Node/Deno module (although it's unlikely you have a video stream named mod.ts, but who knows).

Describe the solution you'd like

A pure Deno project are unlikely to contain Node-specific files (node_modules, package.json, etc.), therefore if the directory contains {mod,deps}.{j,t}s while not Node-specific files, the Node version should be hidden.

Describe alternatives you've considered

Accepting the status quo of Node and leave it as-is.

[vladimyr]

This reminds me of the node vs esy (OCaml's npm so to say) situation. It is handled by mutual exclusion conditions in the module code which we could apply here as well?

[vladimyr]

So my wish is if possible, Starship can check if any of the .ts files is plain text before deciding to show Node/Deno module (although it's unlikely you have a video stream named mod.ts, but who knows).

FWIW, we could check file magic to ensure it is not a video stream but I don't think it's worth time doing. It is simply a too rare event to be handled gracefully.

[kidonng]

This reminds me of the node vs esy (OCaml's npm so to say) situation. It is handled by mutual exclusion conditions in the module code which we could apply here as well?

Awesome! Looks like it's what we need exactly.

[kidonng]

FWIW, we could check file magic to ensure it is not a video stream but I don't think it's worth time doing. It is simply a too rare event to be handled gracefully.

Well, I'm aware that the benefits may not worth it... It's not the main aim of this issue, just bringing up the idea though.

[sant123]

This is my workaround for Node.js projects

[nodejs]
detect_extensions = []

Since detect_files and detect_folders should be enough.

[kidonng]

This is my workaround for Node.js projects

[nodejs]
detect_extensions = []

Since detect_files and detect_folders should be enough.

I wonder, if one day we can drop detect_extensions from nodejs module by default (or just leave Node-specific .{c,m}{j,t}s).

Node.js still remains the one true JavaScript runtime, let's see if Deno could become compelling enough to warrant its place.

[matchai]

@kidonng That would be the end goal of #3673
Instead of checking whether you're in a nested directory of a project, which requires us to check for possible related extensions, we would just check the repo root for relevant project-wide files.