Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize env_var display order in format like what can be done for custom #3259

Closed
segevfiner opened this issue Nov 22, 2021 · 2 comments · Fixed by #4497
Closed

Customize env_var display order in format like what can be done for custom #3259

segevfiner opened this issue Nov 22, 2021 · 2 comments · Fixed by #4497
Labels
✨ enhancement A new feature implementation.

Comments

@segevfiner
Copy link
Contributor

Feature Request

Is your feature request related to a problem? Please describe.

Can't reorder multiple env_var sections individually using format.

Describe the solution you'd like

I want to be able to reorder env_var the same as you can reorder custom sections by including ${custom.section} in the format.

e.g.

format = "${env_var.WSL_DISTRO_NAME}$all"

[env_var.WSL_DISTRO_NAME]
format = "[$env_value]($style) in "
style = "bold dimmed green"

Describe alternatives you've considered

Using custom instead of env_var.

@segevfiner segevfiner added the ✨ enhancement A new feature implementation. label Nov 22, 2021
@segevfiner segevfiner changed the title Customize env_var display order in format like what can be done for cusom Customize env_var display order in format like what can be done for custom Nov 22, 2021
segevfiner added a commit to segevfiner/starship that referenced this issue Jan 1, 2022
segevfiner added a commit to segevfiner/starship that referenced this issue Jan 1, 2022
@rashil2000
Copy link
Contributor

Wow, I'd also love this feature. Incidentally I use WSL_DISTRO_NAME too, along with MSYSTEM. But they always appear together :(

[env_var.WSL_DISTRO_NAME]
format = " [$env_value]($style)"
style = "underline purple"

[env_var.MSYSTEM]
format = " [$env_value]($style)"
style = "underline purple"

@junosuarez
Copy link
Contributor

Thanks for opening this issue, and awesome work starting #3375, @segevfiner. Do you have plans on continuing that PR? If now's not a good time for you, I may have some bandwidth to pick it up and make the needed revisions for it to land. Please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement A new feature implementation.
Projects
None yet
3 participants