Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable Undistract Me for Linux #3547

Merged
merged 1 commit into from Jan 31, 2022

Conversation

schrieveslaach
Copy link
Contributor

Description

In #1019 the undistract feature has been added to starship without
enabling it by default due to the system dependency on libdbus. With
recent versions of notify-rust the dependency is no longer required and
the feature can be enabled by default.

Motivation and Context

Closes #

Screenshots (if appropriate):

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux
  • I have tested using Windows

Checklist:

  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

In starship#1019 the undistract feature has been added to starship without
enabling it by default due to the system dependency on libdbus. With
recent versions of notify-rust the dependency is no longer required and
the feature can be enabled by default.
@chipbuster
Copy link
Contributor

Sweet! @schrieveslaach thanks for the update, and thanks for reviewing @andytom.

@chipbuster chipbuster merged commit dcf6665 into starship:master Jan 31, 2022
@schrieveslaach schrieveslaach deleted the enable-undistract-me branch February 1, 2022 10:03
@schrieveslaach
Copy link
Contributor Author

@chipbuster, thanks for merging!

@davidkna davidkna mentioned this pull request Feb 3, 2022
5 tasks
@trajano
Copy link

trajano commented Feb 8, 2022

Is this available on Windows?

@chipbuster
Copy link
Contributor

Yes, I believe this should now build on Windows by default. The problem was that notify-rust depended on a piece of software on Linux that wasn't installed by default.

Windows never relied on this, so it should be available natively if you enable it. See here for the settings to enable it (specifically, anything with notification in the name)

Perniciosius pushed a commit to Perniciosius/starship that referenced this pull request Feb 21, 2022
In starship#1019 the undistract feature has been added to starship without
enabling it by default due to the system dependency on libdbus. With
recent versions of notify-rust the dependency is no longer required and
the feature can be enabled by default.
@happysalada
Copy link
Contributor

hey, sorry to bother, on nix and darwin (macos) we are experiencing compilation problems with this depedency.
If I made a PR to put notify-rust behind a feature flag and enable it by default, would you be ok with this ?
(adding the feature, would be just to disable it for darwin on nix)

There are various discussions as to where exactly the problem is coming from, but until we find a solution, it would be much easier to have this disable-able.

@davidkna
Copy link
Member

@happysalada Sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants