-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cmd_duration): make notify feature optional (compat with nix darwin) #3855
Conversation
Semantic pull request is unhappy, is this a feat or a fix ? |
I would consider this a feat. Please don't disable the whole |
a3fbe7a
to
8dceb6a
Compare
I've only made the calls to the notification optional. |
8dceb6a
to
94da060
Compare
alright, I think I've got it this time. |
94da060
to
cfe5f76
Compare
my bad for forgetting those, fixed and pushed. |
Thanks for the contribution @happysalada! |
Description
the notify-rust has some very cryptic compilation error on nix and darwin. (reference issue NixOS/nixpkgs#160876)
In the meanwhile, version has been moved forward in nix to not penalize linux users.
Hopefully we can find the source of the error, but in the meanwhile, making this dependency optional is very helpful!
Thank you again for your terminal! (going a month without it, feels like going back to the stone age #addicted)
Motivation and Context
Closes #
Screenshots (if appropriate):
How Has This Been Tested?
I ran
cargo test
,cargo test --no-default-features
,cargo clippy --all-features --all-targets
and couldn't find problems with it, let me know however if you need changes.Checklist: