docs: Specify MSRV #3742
Merged
docs: Specify MSRV #3742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidkna
approved these changes
Mar 12, 2022
|
Thank you for your contribution @tomocrafter and thanks for reviewing @davidkna. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
starship now uses
std::thread::available_parallelismwhich stablized at Rust version 1.59.https://github.com/starship/starship/blob/master/src/main.rs#L235
therefore, This PR sets MSRV to 1.59 to make sure everyone can build.
Does same thing as #3722 , but I deleted forked repository because I thought #3719 would be merged.
Let me know if my English is wrong in the comments with correct sentense. I will fix it quickly.
Motivation and Context
Closes #3716
Closed #3719
Screenshots (if appropriate):
How Has This Been Tested?
Checklist: