Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Specify minimum supported rust version (MSRV) to 1.59 #3722

Closed
wants to merge 1 commit into from
Closed

docs: Specify minimum supported rust version (MSRV) to 1.59 #3722

wants to merge 1 commit into from

Conversation

tomocrafter
Copy link
Contributor

@tomocrafter tomocrafter commented Mar 9, 2022

Description

starship now uses std::thread::available_parallelism which stablized at Rust version 1.59.
https://github.com/starship/starship/blob/master/src/main.rs#L235
therefore, This PR sets MSRV to 1.59 to make sure everyone can build.

Motivation and Context

Closes #3716
Closed #3719

Screenshots (if appropriate):

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux
  • I have tested using Windows

Checklist:

  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

@tomocrafter
Copy link
Contributor Author

tomocrafter commented Mar 9, 2022

I apologize that I haven't seen this PR #3719. closing this PR.

@tomocrafter tomocrafter closed this Mar 9, 2022
@andytom
Copy link
Member

andytom commented Mar 11, 2022

It looks like #3719 has stalled a bit so feel free to reopen this PR. I think all you need to do is run dprint fmt to fix the formatting issues.

@davidkna
Copy link
Member

Please also add a comment that the MSRV is only intended as a hint and that only the latest version is officially supported.
CI testing is currently not looking at older rust versions at all, so this declaration is likely to break in the future without further changes.

@tomocrafter tomocrafter mentioned this pull request Mar 12, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fails to build on older rust versions
3 participants