New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Getting a package version from gradle.properties is not implemented correctly #4759
Labels
🐛 bug
Something isn't working as expected.
Comments
swpalmer
added a commit
to swpalmer/starship
that referenced
this issue
Dec 26, 2022
4 tasks
This was referenced Feb 25, 2023
This was referenced Apr 11, 2023
Indyandie
pushed a commit
to Indyandie/starship
that referenced
this issue
Jul 26, 2023
….properties (starship#4760) fix: Improve regex for extracting gradle package version from gradle.properties (starship#4759)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Current Behavior
Commented out lines in gradle.properties with 'version=' will be matched as defining a version. versions defined with whitespace between 'version' and '=' will not be extract properly.
Expected Behavior
Comment lines should be ignored. Whitespace should be allowed on either side of '='.
Additional context/Screenshots
E.g. this content in a gradle.properties file should NOT set the version to 0.0.1
Possible Solution
Fix the regex on this line https://github.com/starship/starship/blob/master/src/modules/package.rs#L108
Environment
The text was updated successfully, but these errors were encountered: