fix(package): Improve regex for extracting gradle version from gradle.properties #4760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andytom
changed the title
davidkna
approved these changes
Dec 26, 2022
This was referenced Feb 25, 2023
This was referenced Apr 11, 2023
Indyandie
pushed a commit
to Indyandie/starship
that referenced
this pull request
Jul 26, 2023
….properties (starship#4760) fix: Improve regex for extracting gradle package version from gradle.properties (starship#4759)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed regex to
(?m)^\s*version\s*=\s*(?P<version>.*)to account for comment lines and possible whitespace.Motivation and Context
Closes #4759
How Has This Been Tested?
Added test with build.gradle file that contains commented out
version=that was picked up by previous regex and with whitespace around the '='Checklist: