Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pastel-powerline): remove $path from docker-context module format string #5534

Merged
merged 1 commit into from Nov 2, 2023

Conversation

maxmynter
Copy link
Contributor

@maxmynter maxmynter commented Oct 27, 2023

Description

I removed the $path attribute for the docker context in the Pastel Powerline preset. The $path attribute does not exist for docker context as per your documentation.

With the $path present. there is an unpleasant one letter wide vertical gap in the prompt background where the non-existent $path is not rendered.

Motivation and Context

Fixes a visual bug in the pastel powerline preset.

Screenshots (if appropriate):

Before removal of $path:
Screenshot 2023-10-27 at 17 16 40

After removal of $path:
Screenshot 2023-10-27 at 17 17 58

How Has This Been Tested?

  • I have tested using MacOS

  • I have tested using Linux

  • I have tested using Windows

Checklist:

  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

@davidkna davidkna changed the title Remove $path from docker-context in pastel-powerline starship.toml fix(paste-powerline): remove $path from docker-context module format string Nov 2, 2023
@davidkna davidkna changed the title fix(paste-powerline): remove $path from docker-context module format string fix(pastel-powerline): remove $path from docker-context module format string Nov 2, 2023
@davidkna davidkna merged commit 6abc83d into starship:master Nov 2, 2023
4 checks passed
@davidkna
Copy link
Member

davidkna commented Nov 2, 2023

Thanks for fixing this @maxmynter!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants