Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCKER_HOST contains unix:// should be skipped #5548

Closed
zodman opened this issue Nov 3, 2023 · 1 comment · Fixed by #5616 or #5348
Closed

DOCKER_HOST contains unix:// should be skipped #5548

zodman opened this issue Nov 3, 2023 · 1 comment · Fixed by #5616 or #5348
Assignees
@ananta
Labels
🐛 bug Something isn't working as expected. 🌱 good first issue Good first issue to get your feet wet.

Comments

@zodman
Copy link

zodman commented Nov 3, 2023 •
edited

Bug Report

Current Behavior

export DOCKER_HOST="unix://$(podman info --format '{{.Host.RemoteSocket.Path}}')"
touch docker-compose.yaml

the shell showup:

via  unix:///run/user/1001/podman/podman.sock

Possible Solution

if the docker_host contains unix:// the display should be skipped

Environment

pkg_version:1.16.0
branch:master
commit_hash:
build_time:2023-07-30 13:37:26 +00:00
build_env:rustc 1.71.0 (8ede3aae2 2023-07-12),

Relevant Shell Configuration

bash

Starship Configuration

default config
@zodman zodman added the 🐛 bug Something isn't working as expected. label Nov 3, 2023
@andytom andytom added the 🌱 good first issue Good first issue to get your feet wet. label Nov 30, 2023
@ananta
Copy link
Contributor

ananta commented Dec 4, 2023

@zodman I would love to work on this :)

ananta added a commit to ananta/starship that referenced this issue Dec 4, 2023
@ananta
fix(modules): ignore unix domain socket path from Docker Context
7b6a79a 
fix starship#5548
@ananta ananta mentioned this issue Dec 4, 2023
Merged
2 tasks
ananta added a commit to ananta/starship that referenced this issue Dec 16, 2023
@ananta
fix(modules): ignore unix domain socket path from Docker Context
851cbb5 
fix starship#5548
ananta added a commit to ananta/starship that referenced this issue Dec 16, 2023
@ananta
refactor(docker_context): ignore docker_context on unix domain socket…
aa8a374 
… path

Closes starship#5548
andytom pushed a commit that referenced this issue Dec 17, 2023
@ananta
fix(docker_context): ignore unix domain socket path from Docker Conte…
a910e09 
…xt (#5616)

* fix(modules): ignore unix domain socket path from Docker Context

fix #5548

* refactor(docker_context): ignore docker_context on unix domain socket path

Closes #5548
@github-actions github-actions bot mentioned this issue Dec 17, 2023
Merged
@chiefmikey chiefmikey mentioned this issue Dec 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ananta ananta

Labels
🐛 bug Something isn't working as expected. 🌱 good first issue Good first issue to get your feet wet.
Projects
None yet
Milestone
No milestone
3 participants
@zodman @andytom @ananta