Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add configuration for add_newline #116

Merged
merged 3 commits into from
Jul 27, 2019
Merged

feat: Add configuration for add_newline #116

merged 3 commits into from
Jul 27, 2019

Conversation

matchai
Copy link
Member

@matchai matchai commented Jul 25, 2019

Description

  • Replace TableExt with a Config trait that extends toml::value::Table
  • Add configuration for add_newline
    add_newline is a root-level configuration value. When set to false, the initial newline before the prompt is removed.

What are your thoughts on making add_newline a root-level config value?

Motivation and Context

Closes #

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Screenshots (if appropriate):

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux
  • I have tested using Windows

Checklist:

  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

@matchai matchai marked this pull request as ready for review July 25, 2019 19:35
@matchai matchai requested a review from a team July 25, 2019 19:35
@matchai matchai added the ✨ enhancement A new feature implementation. label Jul 25, 2019
@matchai matchai mentioned this pull request Jul 27, 2019
8 tasks
@matchai matchai merged commit 0bc28c5 into master Jul 27, 2019
@matchai matchai deleted the newline-config branch July 27, 2019 22:25
@matchai matchai restored the newline-config branch July 27, 2019 22:25
@matchai matchai deleted the newline-config branch July 27, 2019 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement A new feature implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant