-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add xonsh support #1265
feat: Add xonsh support #1265
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks great to me! Thank you for taking the time to add docs everywhere they're needed. 😄
Unfortunately, I seem to be having issues getting starship working, following the provided instructions.
I appear to get the following error after editing ~/.xonshrc
or running execx($(starship init xonsh))
directly:
NameError: name 'get_next_job_number' is not defined
I see the get_next_job_number
function is clearly imported at the start of your init file, but I'm not familiar enough with xonsh to know where to start troubleshooting.
I have installed xonsh directly from Brew (xonsh/0.9.18) if that's of any help.
If I can provide any details to help troubleshoot, let me know. If you'd prefer more synchronous communication while troubleshooting, I'm always available on the project Discord: https://discord.gg/8Jzqu3T
I'm giving my best 😁
Well, we took different routes. I've installed it using
Sure, I'll join 👍 |
Well, this reached a dead end 😞 The main difference between Homebrew and pip/x install of xonsh is that Homebrew installs optional prompt-toolkit too. Without it, xonsh simply uses readline and works fine with ANSI escape sequences. With prompt-toolkit in use, things go wrong xonsh/xonsh#1403 so even if I figure out import error there is still a bigger wall to hit. With that being said and because I'm not a python expert and don't have enough time/knowledge to dive deep into xonsh/ptk internals I think it is fair to give up here. I'm sorry, I hope I put up a good fight ⚔️ |
I've ported starship as xontrib-prompt-starship |
This is not true anymore. Xonsh now properly supports escape sequences with Kudos to @anki-code for following xonsh/xonsh#1403 and bringing this to my attention 👍 Thus restarting this effort... |
What would it take to get this PR merged? 🙏 |
Description
Adds
xonsh
init script.Motivation and Context
Closes #272
Screenshots (if appropriate):
How Has This Been Tested?
Checklist: