Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement the ruby module #131

Merged
merged 9 commits into from Aug 13, 2019
Merged

Conversation

AZanellato
Copy link
Contributor

Description

Motivation and Context

There isn't a ruby prompt, which is one more language for the prompt.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Screenshots (if appropriate):

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux
  • I have tested using Windows

Checklist:

  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

@AZanellato AZanellato changed the title Add ruby info to the prompt [WIP] Add ruby info to the prompt Aug 10, 2019
@matchai matchai added the ✨ enhancement A new feature implementation. label Aug 10, 2019
@AZanellato AZanellato changed the title [WIP] Add ruby info to the prompt Feat: Add ruby info to the prompt Aug 12, 2019
@AZanellato AZanellato changed the title Feat: Add ruby info to the prompt feat: implement the ruby module Aug 12, 2019
Copy link
Member

@matchai matchai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking the time to add a Ruby module! 😄
Your PR looks great. Before we merge it in, can we add a Ruby heading to the config docs? The only configuration that should be present is the disabled option. https://github.com/starship/starship/tree/master/docs/config

Also, it would be great if we could add "Ruby" to the features list on README.md! 💎

src/modules/ruby.rs Outdated Show resolved Hide resolved
src/modules/ruby.rs Outdated Show resolved Hide resolved
Copy link
Member

@matchai matchai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!
The PR looks good to me. 😄

@matchai matchai merged commit b06249d into starship:master Aug 13, 2019
@matchai
Copy link
Member

matchai commented Aug 14, 2019

@all-contributors please add @AZanellato for code, docs and tests.

@allcontributors
Copy link
Contributor

@matchai

I've put up a pull request to add @AZanellato! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement A new feature implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants