Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a Lua module #1815

Merged
merged 9 commits into from
Oct 27, 2020
Merged

feat: Add a Lua module #1815

merged 9 commits into from
Oct 27, 2020

Conversation

cappyzawa
Copy link
Member

@cappyzawa cappyzawa commented Oct 21, 2020

Description

I added an module for The Programming Language Lua.

Motivation and Context

Closes #

Screenshots (if appropriate):

スクリーンショット 2020-10-22 3 41 04

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux
  • I have tested using Windows

Checklist:

  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

@cappyzawa cappyzawa changed the title feat: Add Lua module feat: Add a Lua module Oct 21, 2020
@cappyzawa cappyzawa marked this pull request as ready for review October 21, 2020 18:42
@cappyzawa cappyzawa requested a review from a team October 21, 2020 18:42
src/modules/lua.rs Outdated Show resolved Hide resolved
@cappyzawa
Copy link
Member Author

@davidkna I've fixed based on #1815 (comment) 🙆‍♂️

src/modules/lua.rs Outdated Show resolved Hide resolved
Copy link
Member

@davidkna davidkna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/config/README.md Outdated Show resolved Hide resolved
@andytom andytom merged commit c6d25a6 into master Oct 27, 2020
@andytom andytom deleted the feature/lua branch October 27, 2020 18:05
@andytom
Copy link
Member

andytom commented Oct 27, 2020

Thank you for your contribution @cappyzawa and thank you for reviewing @davidkna .

chipbuster pushed a commit to chipbuster/starship that referenced this pull request Jan 14, 2021
* feat: add lua module

* docs: add lua module

* fix: lua version test

* feat: lua module can be detected if the current dir contains a "lua" dir

* feat: enable to use luajit

* fix: improve regex

* fix based on starship#1815 (comment)

* fix based on starship#1815 (comment)

* fix based on starship#1815 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants