feat: add host module #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chipbuster
reviewed
Sep 4, 2019
There was a problem hiding this comment.
Thanks for the PR @ahouts! Can't wait to get this into the trunk.
You've done a great job with most of this. There's just a few small styling/convention tweaks I'd like to do and a few questions I'd like to have answered just so that I understand some of the implications.
After that, we can get this baby merged!
added 2 commits
September 4, 2019 08:00
This reverts commit 6af2cd9.
|
@chipbuster changes from the review are pushed |
Co-Authored-By: Matan Kushner <hello@matchai.me>
|
Thank you for your contribution, Andrew! 😄 @all-contributors Please add @ahouts for code, docs and test! |
|
I've put up a pull request to add @ahouts! 🎉 |
|
Thanks Andrew. I can't wait to use this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a host module as requested by @chipbuster.
Displays the system hostname as provided by gethostname.
Motivation and Context
Closes #157
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?
Checklist: