fix: replace battery with starship-battery #3213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 26, 2022
This was referenced Aug 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces the unmaintained
rust-batterydependency with a fork owned by the starship org,starship-battery.The aim of this fork is to not deviate too far from the original, only merging fixes for known issues affecting Starship or restricting any planned features.
Besides some reshuffling of the repo, the only two meaningful changes in our fork so far have been:
Merging the following two PRs in the original repo:
FullyChargedandDesignCapacitysvartalf/rust-battery#93Motivation and Context
Closes #2800
Screenshots (if appropriate):
How Has This Been Tested?
Checklist: