Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix default order in docs #376

Merged
merged 2 commits into from Sep 15, 2019
Merged

docs: Fix default order in docs #376

merged 2 commits into from Sep 15, 2019

Conversation

nrabulinski
Copy link
Contributor

@nrabulinski nrabulinski commented Sep 15, 2019 •
edited

Description and Motivation

the default order seen in docs/config/README.md is different than the one in src/print.rs

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux
  • I have tested using Windows

Checklist:

  • I have updated the documentation accordingly. (Obviously)
  • I have updated the tests accordingly.

@nrabulinski nrabulinski changed the title fix: wrong default order in the docs docs: wrong default order Sep 15, 2019
matchai
matchai approved these changes Sep 15, 2019
View reviewed changes
Copy link
Member

@matchai matchai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 👍
Thank you for submitting a fix. 😄

@matchai matchai changed the title docs: wrong default order docs: Fix default order in docs Sep 15, 2019
@matchai matchai merged commit 8014e92 into starship:master Sep 15, 2019
@nrabulinski nrabulinski deleted the doc-fix branch September 15, 2019 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matchai matchai matchai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nrabulinski @matchai