Install a fixed version of rust for CI integration tests #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
April 29, 2019 20:44
matchai
force-pushed
the
clean-up-pipelines
branch
from
7260beb
to
21b9c11
Compare
|
@Multimo Do you think I'm overcomplicating this, or do you think this complexity makes sense? |
Multimo
approved these changes
May 1, 2019
| @@ -1,4 +1,4 @@ | |||
| FROM rust:latest | |||
| FROM rust:1.34.0 | |||
There was a problem hiding this comment.
This makes sense. :latest will always grab the latest version and would invalidate the tests so this is legit 👍
| @@ -24,7 +24,8 @@ RUN mkdir benches | |||
| RUN touch benches/my_benchmark.rs | |||
|
|
|||
| # This is a dummy build to get dependencies cached | |||
| RUN cargo build --release | |||
| RUN rustup install stable | |||
| RUN rustup run stable cargo build --release | |||
There was a problem hiding this comment.
I am honestly not sure about the significance of this? Could you expand a little why you made this change? Wouldn't the version of rust specified in the docker image default to stable?
matchai
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make
rustupinstall a specific version of Rust along with the required Rust toolchain to run the build and tests.azure-pipelines.ymlrustup runusing the required toolkitMotivation and Context
In order to be able to have integration tests that run
rust --version, we need the locally used Rust to be a fixed version, while running tests and builds with the current stable/beta/nightly.Types of changes
Screenshots (if appropriate):
How Has This Been Tested?
Checklist: