fix(nu): use the most recent starship init #3908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
This was referenced Jun 26, 2022
This was referenced Aug 14, 2022
This was referenced Feb 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The old nushell init approach caused the init only to update if the shell was opened a second time due to how nu handles sourcing (#3773 (comment)).
Thanks to @ajeetdsouza (thanks for notifying me!), there's a different approach that doesn't have this issue, by utilizing the nushell env file: nushell/nushell#4773 (comment)
The default env file also contains some prompt-related configuration, so using it for this seems reasonable. The supported nushell version needed to be raised to 0.61, because that version introduced the env file feature.
Motivation and Context
Closes #
Screenshots (if appropriate):
How Has This Been Tested?
Checklist: