Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(status): replace multiply with cross mark emoji #4461

Merged
merged 1 commit into from Oct 15, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/config-schema.json
Expand Up @@ -1341,7 +1341,7 @@
"signal_symbol": "⚡",
"style": "bold red",
"success_symbol": "",
"symbol": ""
"symbol": ""
},
"allOf": [
{
Expand Down Expand Up @@ -4633,7 +4633,7 @@
"type": "string"
},
"symbol": {
"default": "",
"default": "",
"type": "string"
},
"success_symbol": {
Expand Down
2 changes: 1 addition & 1 deletion docs/config/README.md
Expand Up @@ -3397,7 +3397,7 @@ To enable it, set `disabled` to `false` in your configuration file.
| Option | Default | Description |
| --------------------------- | ----------------------------------------------------------------------------- | --------------------------------------------------------------------- |
| `format` | `"[$symbol$status]($style) "` | The format of the module |
| `symbol` | `""` | The symbol displayed on program error |
| `symbol` | `""` | The symbol displayed on program error |
| `success_symbol` | `""` | The symbol displayed on program success |
| `not_executable_symbol` | `"🚫"` | The symbol displayed when file isn't executable |
| `not_found_symbol` | `"🔍"` | The symbol displayed when the command can't be found |
Expand Down
2 changes: 1 addition & 1 deletion src/configs/status.rs
Expand Up @@ -30,7 +30,7 @@ impl<'a> Default for StatusConfig<'a> {
fn default() -> Self {
StatusConfig {
format: "[$symbol$status]($style) ",
symbol: "",
symbol: "",
success_symbol: "",
not_executable_symbol: "🚫",
not_found_symbol: "🔍",
Expand Down
8 changes: 4 additions & 4 deletions src/modules/status.rs
Expand Up @@ -323,12 +323,12 @@ mod tests {
for status in &exit_values {
let expected = Some(format!(
"{} ",
Color::Red.bold().paint(format!("{}", status))
Color::Red.bold().paint(format!("{}", status))
));
let actual = ModuleRenderer::new("status")
.config(toml::toml! {
[status]
symbol = ""
symbol = ""
disabled = false
})
.status(*status)
Expand All @@ -345,12 +345,12 @@ mod tests {
for (exit_value, string_value) in exit_values.iter().zip(string_values) {
let expected = Some(format!(
"{} ",
Color::Red.bold().paint(format!("{}", string_value))
Color::Red.bold().paint(format!("{}", string_value))
));
let actual = ModuleRenderer::new("status")
.config(toml::toml! {
[status]
symbol = ""
symbol = ""
disabled = false
format = "[${symbol}${hex_status}]($style) "
})
Expand Down