-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kubernetes): Allow to filter context names #4505
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems fine, but please rename the option to ignore_contexts
to better align with similar options elswhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but we may want to wait how #614 etc. progress before merging.
No rush, but is that PR related somehow? I know it would allow conditional formatting based on the context name. I couldn't see a way to just ignore a context. |
@DanielKneipp I was thinking it might make sense to move the |
@davidkna Agreed! this way we can have all context-related config unified. I might have some time to check this out later this weekend. Should I commit on #4550 or is a new PR preferred after this one gets merged? What do you guys think @davidkna @jankatins ? |
@DanielKneipp I would appreciate a review of #4550 and it's probably best to wait for a comment by one of the starship maintainer on what direction #4550 should take (there was not yet any maintainer review on that PR). :-) |
This PR would need a rebase (and probably a rework :-() now that #4550 is merged. I would also really love to have this. @DanielKneipp |
@DanielKneipp Do you think you still find time (and interest) to finish this PR or would it be ok if I take this over to rebase and rework it (in a new PR with your name as coauthor in the commit). |
Oh feel free @jankatins! By the way, I also added some other |
Allow filtering of kubernetes context names
Description
This change should allow the user to specify a list of namespace names to be ignored via the variable
filter_contexts
. Any context that matches a name on this list will be ignored.Motivation and Context
This is to allow the user to ignore regular local contexts like
docker-desktop
. Basically, I want to have a way to ignore the default context I have.How Has This Been Tested?
Tested with
cargo test kubernetes
Checklist: