Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(preset): Add no-nerd-font preset #4517

Merged
merged 4 commits into from Nov 1, 2022

Conversation

segevfiner
Copy link
Contributor

@segevfiner segevfiner commented Oct 22, 2022

Description

Add powerline-only-symbols preset.

Feel free to iterate on this and add actual icons for Erlang and Pulumi or chnage the suggested icons to ones you like better.

This will help until the project decides to release a major version with a clear separation between the default preset and Nerd Fonts preset. And will also give a chance to iterate on the new symbols.

cc @chipbuster

Motivation and Context

Related to #2563 & #3544

Screenshots (if appropriate):

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux
  • I have tested using Windows

Checklist:

  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

@chipbuster
Copy link
Contributor

@segevfiner Currently working out a few typos and other things. Two thoughts for this preset:

  1. I think the name "powerline only" is a little misleading in this case, because it's really powerline + emoji. What do you think about either "no-nerd-font" or "powerline-emoji-only"?

  2. I don't think we need a screenshot for this preset. This is partially because I managed to lose the script I used to take the last set of screenshots (oops),but also because only a few symbols are changed here, and none of those symbols are displayed in the standard preset screenshots. We'd need to create a custom set of commands to show it off, and I just don't think that's worth the confusion when you can read the entire preset in 5 seconds. Do you think this makes sense or would you prefer to do something else?

@chipbuster
Copy link
Contributor

Also, for the time being, I've decided to go with "letter 'e' in a circle" for Erlang and "ice cube" for pulumi. I'm not terribly happy with either, but I think it's preferable to keep the convention of 1-2 character widths for a module symbol in everything but the plain text preset.

[erlang]
symbol = "ⓔ "

[nodejs]
symbol = "[⬢](bold green) "

[pulumi]
symbol = "🧊 "

@segevfiner
Copy link
Contributor Author

@segevfiner Currently working out a few typos and other things. Two thoughts for this preset:

  1. I think the name "powerline only" is a little misleading in this case, because it's really powerline + emoji. What do you think about either "no-nerd-font" or "powerline-emoji-only"?
  2. I don't think we need a screenshot for this preset. This is partially because I managed to lose the script I used to take the last set of screenshots (oops),but also because only a few symbols are changed here, and none of those symbols are displayed in the standard preset screenshots. We'd need to create a custom set of commands to show it off, and I just don't think that's worth the confusion when you can read the entire preset in 5 seconds. Do you think this makes sense or would you prefer to do something else?
  1. I'm fine with either name IMHO.
  2. A screenshot for this is not really critical I guess. We can produce one manually if we have too. But this is something that can always be added later even if we don't add it now.

@davidkna davidkna changed the title feat(preset): Add powerline-only-symbols preset feat(preset): Add no-nerdfonts preset Oct 30, 2022
@davidkna davidkna changed the title feat(preset): Add no-nerdfonts preset feat(preset): Add no-nerd-font preset Oct 30, 2022
@andytom andytom merged commit 4d86a4c into starship:master Nov 1, 2022
Indyandie pushed a commit to Indyandie/starship that referenced this pull request Jul 26, 2023
* feat(preset): Add powerline-only-symbols preset

Related to starship#2563 & starship#3544

* Modify symbols for pulumi and erlang

* Change some wording and add default notification

* Update name of preset

Co-authored-by: Kevin Song <chips@ksong.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants