Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(loadavg): add module for load average #4594

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cgzones
Copy link
Contributor

@cgzones cgzones commented Nov 12, 2022

Example configuration:

[loadavg]
disabled = false

[[loadavg.display]]
threshold_one = 8.0
style = "bold red"

[[loadavg.display]]
threshold_one = 4.0
style = "bold yellow"

[[loadavg.display]]
threshold_one = 2.0
style = "bold white"

[[loadavg.display]]
threshold_one = 0.0
style = "dimmed white"

Description

Add a module to show the system load average.

Motivation and Context

Inspired by #1252 (comment)

Screenshots (if appropriate):

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux
  • I have tested using Windows

Checklist:

  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

@cgzones cgzones force-pushed the loadavg branch 4 times, most recently from 1e76073 to 1fb4e1b Compare November 13, 2022 15:15
@davidkna
Copy link
Member

I think this should support Windows before merging.

@cgzones cgzones force-pushed the loadavg branch 2 times, most recently from 05a13d0 to 16fd3c2 Compare November 14, 2022 19:00
@cgzones
Copy link
Contributor Author

cgzones commented Nov 25, 2022

What would be a good replacement metric on Windows?

Inspired by starship#1252 (comment)

Example configuration:

    [loadavg]
    disabled = false

    [[loadavg.display]]
    threshold_one = 8.0
    style = "bold red"

    [[loadavg.display]]
    threshold_one = 4.0
    style = "bold yellow"

    [[loadavg.display]]
    threshold_one = 2.0
    style = "bold white"

    [[loadavg.display]]
    threshold_one = 0.0
    style = "dimmed white"
@cgzones
Copy link
Contributor Author

cgzones commented Feb 26, 2023

Since the module is disabled by default, is it necessary to support Windows? See for example the sudo module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants